ref(proguard): Deobfuscate view hierarchies as part of symbolication #74196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
loewenheim
commented
Jul 12, 2024
There was a problem hiding this comment.
Changes in this file look much worse than they are. Basically we need to make the test compatible with Symbolicator, so it needs with set_sentry_option("system.url-prefix", live_server.url): at the beginning.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74196 +/- ##
========================================
Coverage 78.14% 78.15%
========================================
Files 6650 6650
Lines 297301 297042 -259
Branches 51186 51112 -74
========================================
- Hits 232326 232153 -173
+ Misses 58708 58659 -49
+ Partials 6267 6230 -37
|
Swatinem
reviewed
Jul 15, 2024
Swatinem
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on getsentry/symbolicator#1496.
This moves view hierarchy deobfuscation out of the plugin/preprocessor and into symbolication. That allows us to remove proguard processing from Sentry entirely and only have it in Symbolicator.
Since this means we would potentially want to send JVM events to Symbolicator that don't have exceptions or stacktraces, we have to be more lenient when detecting such events (see the change to
is_jvm_event). I don't think this presents a problem—we still check if the event contains anything that needs to be symbolicated before we actually send it.The bigger problem is that merely modifying theThis was due to some trivial mistake or other that got fixed along the way.attachment_cachethe way I'm doing right now doesn't appear to be enough to actually save the modified attachment. The current code where that happens in the preprocessor does just that, but I assume there is some point where the cache is persisted that we don't hit if we do this in symbolication. I need to understand this better.